Skip to content

feat: use hatchling, drop setuptools #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 16, 2025
Merged

feat: use hatchling, drop setuptools #1323

merged 9 commits into from
Nov 16, 2025

Conversation

@onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Aug 25, 2025 •
edited
Loading

closes #664

@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 3 times, most recently from f7a43c1 to 27cb9ad Compare August 25, 2025 21:44
@shiftinv shiftinv added t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.) labels Aug 26, 2025
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 2 times, most recently from 0d9175a to e7d0b60 Compare August 27, 2025 02:22
@onerandomusername onerandomusername marked this pull request as ready for review August 27, 2025 07:53
@onerandomusername onerandomusername requested a review from a team as a code owner August 27, 2025 07:53
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 3 times, most recently from 4eed882 to 2063c20 Compare September 3, 2025 05:03
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 2 times, most recently from 3785324 to 8a314c4 Compare September 4, 2025 22:52
@shiftinv shiftinv mentioned this pull request Sep 5, 2025
Merged
8 tasks
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from 8a314c4 to 0294825 Compare September 5, 2025 10:09
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 2 times, most recently from 7a2f2b1 to 28ab5b2 Compare September 15, 2025 06:49
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 20, 2025 •
edited
Loading

Documentation build overview

📚 disnake | 🛠️ Build #30341348 | 📁 Comparing 497eb45 against latest (b325cc4)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

shiftinv
shiftinv reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I spent some time looking into hatchling + versioningit, but haven't fully reviewed everything just yet, so here are some preliminary comments:

@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from dd74f06 to 2db92a2 Compare October 15, 2025 08:39
shiftinv
shiftinv reviewed Oct 16, 2025
View reviewed changes
shiftinv
shiftinv reviewed Oct 17, 2025
View reviewed changes
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 4 times, most recently from 6594b5b to ff625d2 Compare October 20, 2025 02:13
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from ff625d2 to 853d9ed Compare October 20, 2025 02:15
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch 2 times, most recently from 91ddca7 to ddaa1f3 Compare October 20, 2025 02:35
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from ddaa1f3 to dbc301d Compare October 20, 2025 03:19
@onerandomusername
fix: use the next version for docs generation
87d6b0f
@onerandomusername
fix: provide a fallback version when the version cannot be determined
9ad626d 
Without this setting, installation of disnake from a source distribution
without source control metadata will fail, because there will be no way
to determine the version of disnake without that metadata.

Using a fallback ensures that in such an installation method (such as
from a GitHub source archive), disnake can still be installed, though
the version metadata may be inaccurate.

Compared to not allowing installation at all, this is a better user
experience, despite the incorrect version information.
@onerandomusername
docs: add changelog
a4ed52b
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from 1d0b983 to a4ed52b Compare October 20, 2025 16:30
@onerandomusername onerandomusername force-pushed the feat/build-with-hatchling branch from cc098a7 to ea9d6a3 Compare November 9, 2025 07:05
shiftinv
shiftinv reviewed Nov 16, 2025
View reviewed changes
.github/workflows/lint-test.yml
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-depth: '0'
Copy link
Member

@shiftinv shiftinv Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming actions/checkout supports it, --shallow-since would be an option to at least limit this a little

shiftinv
shiftinv approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case, looks good to me!

@onerandomusername onerandomusername enabled auto-merge (squash) November 16, 2025 21:41
@onerandomusername onerandomusername merged commit f6bba0f into master Nov 16, 2025
34 checks passed
@onerandomusername onerandomusername deleted the feat/build-with-hatchling branch November 16, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees

No one assigned

Labels

t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider dropping setuptools

2 participants

@onerandomusername @shiftinv